[Merged by Bors] - chore(RingTheory/Ideal/Norm/RelNorm): switch over to new definitions of ramificationIdx and inertiaDeg#41077
Closed
tb65536 wants to merge 5 commits into
Closed
Conversation
tb65536
added
awaiting-CI
github-actions
Bot
added
the
large-import
PR summary c71c87de96Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.DedekindDomain.Factorization | 2155 | 2411 | +256 (+11.88%) |
| Mathlib.RingTheory.Ideal.Norm.RelNorm | 2426 | 2425 | -1 (-0.04%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.Ideal.Norm.RelNorm |
-1 |
Mathlib.AlgebraicGeometry.EllipticCurve.LFunction |
114 |
5 filesMathlib.NumberTheory.Height.NumberField Mathlib.NumberTheory.NumberField.AdeleRing Mathlib.NumberTheory.NumberField.Completion.FinitePlace Mathlib.NumberTheory.NumberField.FinitePlaces Mathlib.NumberTheory.NumberField.ProductFormula |
118 |
Mathlib.RingTheory.DedekindDomain.FiniteAdeleRing |
141 |
Mathlib.Topology.Algebra.Ring.Compact |
218 |
Mathlib.Algebra.Module.Torsion.PrimaryComponent Mathlib.RingTheory.DedekindDomain.Factorization |
256 |
Declarations diff (regex)
+ IsDedekindDomain.ramificationIdx'_eq_factors_count
+ ramificationIdx_eq_ramificationIdx''
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
c71c87d).
- +2 new declarations
- −0 removed declarations
+Ideal.IsDedekindDomain.ramificationIdx'_eq_factors_count
+Ideal.ramificationIdx_eq_ramificationIdx''No changes to strong technical debt.
No changes to weak technical debt.
Current commit c71c87de96
Reference commit 571b8a8e54
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
github-actions
Bot
removed
the
awaiting-CI
Member
|
Thanks! bors merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jun 29, 2026
…of `ramificationIdx` and `inertiaDeg` (#41077) This PR switches the file `RingTheory/Ideal/Norm/RelNorm.lean` over to the new definitions of `ramificationIdx` and `inertiaDeg`. Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
mathlib-bors
Bot
added
the
bors-staging
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
ramificationIdx and inertiaDegramificationIdx and inertiaDeg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the file
RingTheory/Ideal/Norm/RelNorm.leanover to the new definitions oframificationIdxandinertiaDeg.